EYB human readable labels #7452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
data-hub-frontend
|
||||||||||||||||||||||||||||
| Project |
data-hub-frontend
|
| Branch Review |
feature/CLS2-1120-eyb-human-readable-labels
|
| Run status |
|
| Run duration | 08m 35s |
| Commit |
|
| Committer | santosh dasari |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
4
|
Skipped
|
0
|
Passing
|
75
|
| View all changes introduced in this branch ↗︎ | |
santoshdasa12345
force-pushed
the
feature/CLS2-1120-eyb-human-readable-labels
branch
from
b28906d to
19084ed
Compare
dredmonds
approved these changes
Jan 7, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7452 +/- ##
=======================================
Coverage 88.56% 88.56%
=======================================
Files 1159 1159
Lines 18017 18029 +12
Branches 5122 5126 +4
=======================================
+ Hits 15956 15968 +12
Misses 2061 2061 ☔ View full report in Codecov by Sentry. |
santoshdasa12345
changed the title
|
Can you add some tests covering the new code please? |
2 tasks
update import
santoshdasa12345
force-pushed
the
feature/CLS2-1120-eyb-human-readable-labels
branch
from
231ed8b to
a086d3a
Compare
Added |
oliverjwroberts
requested changes
Jan 16, 2025
oliverjwroberts
approved these changes
Jan 16, 2025
santoshdasa12345
force-pushed
the
feature/CLS2-1120-eyb-human-readable-labels
branch
from
c4f54ff to
161ef5a
Compare
santoshdasa12345
deleted the
feature/CLS2-1120-eyb-human-readable-labels
branch
chopkinsmade
pushed a commit
that referenced
this pull request
Jan 16, 2025
…human-readable-labels generated from commit 0165219
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
As Part of the EYB work , converting some fields to human readable fields.
Test instructions
Should see Sentence case in the below fields:
When do you want to set up?
How do you plan to expand your business in the UK?
How many people do you want to hire in the UK in the first 3 years?
Screenshots
Before
After
Checklist